fix(fluent-bit): Listen on IPv6+IPv4#663
Conversation
This fixes fluent#355 Signed-off-by: Jan-Philipp Litza <jplitza@users.noreply.github.com>
lilioid
left a comment
There was a problem hiding this comment.
I can confirm that this works. A fluent-bit process started with http_listen: "::" listens on both IPv4 (so is compatible to the old behavior) as well as IPv6.
I would like to see this merged as well :)
|
It would be great to have it merged, very helpful! |
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @jplitza, please could you make sure you follow the contribution guide.
RE this PR, if you want to make a major change like this you 100% need to open an issue to discuss it (I can't see this change being approved in this state). The current chart will allow you to override http_listen by setting config.service, if you want to make it more customizable you could add a new value but you'd also need to check if 0.0.0.0 is hardcoded anywhere else in the chart and keep that in sync.
If you look at the fluent-bit-aggregator & fluent-bit-collector charts you'll see that this can already be set via config.service.http_listen. I'd strongly recommend that you switch over to one of these charts.
This fixes #355